fix(mapping): restore singular key for FeatureOfInterest in ENTITY_URL_NAMES#182
Open
Vishmayraj wants to merge 1 commit into
Open
fix(mapping): restore singular key for FeatureOfInterest in ENTITY_URL_NAMES#182Vishmayraj wants to merge 1 commit into
FeatureOfInterest in ENTITY_URL_NAMES#182Vishmayraj wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores the singular key
"FeatureOfInterest"in theENTITY_URL_NAMESmapping table. During recent testing of the geometry insertion logic, I encountered a ValueError in build_self_link that was causing the test_feature_key_uses_st_geomfromgeojson test to fail. After debugging the regression, I traced the root cause back to commit 423aba9, where this key was likely updated to its plural form by mistake.I initially questioned if my test logic was incorrect, but after observing that other geometry insertion tests for entities like Location continue to pass using singular keys, I verified the requirement against the
OGC SensorThings APIstandards. The specification confirms that while theURLpath isplural(FeaturesOfInterest), the formalEntity Nameused for creation and internal mapping should remainsingular(FeatureOfInterest). This character fix restores consistency across the mapping table and ensures all unit tests pass as expected.Related Changes
Reverts the mapping change from commit 423aba9.