Perform preemption check only when used as a chained plugin#256
Perform preemption check only when used as a chained plugin#256luksa wants to merge 1 commit intoistio:masterfrom
Conversation
When Istio CNI is not used as a chained plugin, throwing an error or logging the preemption warning doesn't make sense. For example, when using Multus CNI, multiple CNI config files are in the same dir, but none of them has precedence over the others, as they are loaded by name. In that case, logging the warning isn't appropriate.
|
😊 Welcome @luksa! This is either your first contribution to the Istio cni repo, or it's been awhile since You can learn more about the Istio working groups, code of conduct, and contributing guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
|
Hi @luksa. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When Istio CNI is not used as a chained plugin, throwing an
error or logging the preemption warning doesn't make sense.
For example, when using Multus CNI, multiple CNI config
files are in the same dir, but none of them has precedence
over the others, as they are loaded by name. In that case,
logging the warning isn't appropriate.