Skip to content

fix: Set call handling to not use base url as path #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itachi1706 merged 2 commits into from
Oct 2, 2025
Merged

fix: Set call handling to not use base url as path #292

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2d9dc7
fix: Set call handling to not use base url as path
itachi1706 Oct 2, 2025
25c1d83
docs: Add documentation for path
itachi1706 Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion helperlib/src/main/java/com/itachi1706/helperlib/helpers/ApiCallsHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ class ApiCallsHelper(
private var method: Int = Request.Method.GET
private var data: String? = null

private var path: String = ""

/**
* Set the base URL to use for API calls
* @param baseUrl Base URL to use defaults to [DEFAULT_URL]
Expand Down Expand Up @@ -140,6 +142,15 @@ class ApiCallsHelper(
return this
}

/**
* Set the path to use for API calls
* @param path Path to use for API calls
*/
fun setPath(path: String): Builder {
this.path = path
return this
}

/**
* Builds the [ApiCallsHelper]
* @return [ApiCallsHelper]
Expand All @@ -162,7 +173,7 @@ class ApiCallsHelper(
}

val helper = ApiCallsHelper(context, baseUrl, tag, extraHeaders, defaultAuthentication)
helper.internalCallHandling(method, baseUrl, data, callback!!)
helper.internalCallHandling(method, path, data, callback!!)
}
}

Expand Down