Minor changes to docker-compose.yml#18
Open
RyanSawyer6003 wants to merge 2 commits intoitflow-org:mainfrom
Open
Minor changes to docker-compose.yml#18RyanSawyer6003 wants to merge 2 commits intoitflow-org:mainfrom
RyanSawyer6003 wants to merge 2 commits intoitflow-org:mainfrom
Conversation
Added health checks and moved volumes to named locations to prevent issues if ./itflow dir did not exist.
Added Comment for instructions on pulling image from dockerhub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes are to build locally, added health checks, moved volume mount points to named locations to prevent issues if ./itflow does not exist. Also removed it. from before $ROOT_DOMAIN, we should consider changing the .env var from $root_domain to $APP_URL to make this vars usage cleaner and clearer.