Skip to content

Develop to Master for 25.12 release #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johnnyq wants to merge 55 commits into from

refined php-xml ext notice

ca5fb2e
Select commit
Loading
Failed to load commit list.
Closed

Develop to Master for 25.12 release #1249

refined php-xml ext notice
ca5fb2e
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Dec 6, 2025 in 53s

Quality Gate failed

Failed conditions
E Security Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 566 in agent/files_legacy.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Anchor tags should not be used as buttons. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tNiv78fvmSAZUft&open=AZr0_tNiv78fvmSAZUft&pullRequest=1250

Check warning on line 0 in uploads/custom/index.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a new line at the end of this file. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tUQv78fvmSAZUgA&open=AZr0_tUQv78fvmSAZUgA&pullRequest=1250

Check failure on line 111 in js/bulk_actions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `.dataset` over `hasAttribute(…)`. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tUgv78fvmSAZUgE&open=AZr0_tUgv78fvmSAZUgE&pullRequest=1250

Check warning on line 30 in admin/includes/side_nav.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tS6v78fvmSAZUf_&open=AZr0_tS6v78fvmSAZUf_&pullRequest=1250

Check warning on line 1571 in functions.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "display_folder_options" to match the regular expression ^[a-z][a-zA-Z0-9]*$. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tVev78fvmSAZUgG&open=AZr0_tVev78fvmSAZUgG&pullRequest=1250

Check warning on line 65 in agent/post/document.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the useless trailing whitespaces at the end of this line. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tNJv78fvmSAZUfm&open=AZr0_tNJv78fvmSAZUfm&pullRequest=1250

Check warning on line 54 in agent/document_details.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Anchors must have content and the content must be accessible by a screen reader. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tR9v78fvmSAZUf6&open=AZr0_tR9v78fvmSAZUf6&pullRequest=1250

Check failure on line 20 in admin/post/document_template.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "/uploads/document_templates/" 5 times. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tSov78fvmSAZUf-&open=AZr0_tSov78fvmSAZUf-&pullRequest=1250

Check failure on line 112 in js/bulk_actions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `.dataset` over `setAttribute(…)`. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tUgv78fvmSAZUgF&open=AZr0_tUgv78fvmSAZUgF&pullRequest=1250

Check warning on line 835 in functions.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tVev78fvmSAZUgI&open=AZr0_tVev78fvmSAZUgI&pullRequest=1250

Check warning on line 8 in agent/modals/document/document_add_from_template.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

The return value of "intval" must be used. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tGHv78fvmSAZUfi&open=AZr0_tGHv78fvmSAZUfi&pullRequest=1250

Check warning on line 49 in agent/ajax.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use concise character class syntax '\D' instead of '[^0-9]'. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tOHv78fvmSAZUf0&open=AZr0_tOHv78fvmSAZUf0&pullRequest=1250

Check failure on line 435 in agent/files.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the parentheses from this "echo" call. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tQav78fvmSAZUf3&open=AZr0_tQav78fvmSAZUf3&pullRequest=1250

Check warning on line 44 in admin/post/payment_method.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the useless trailing whitespaces at the end of this line. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tSZv78fvmSAZUf9&open=AZr0_tSZv78fvmSAZUf9&pullRequest=1250

Check failure on line 296 in agent/post/file.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this code to not construct SQL queries directly from user-controlled data. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tL9v78fvmSAZUfk&open=AZr0_tL9v78fvmSAZUfk&pullRequest=1250

Check warning on line 378 in agent/files_legacy.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "require" with "require_once". 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tNiv78fvmSAZUfx&open=AZr0_tNiv78fvmSAZUfx&pullRequest=1250

Check warning on line 82 in js/bulk_actions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Handle this exception or don't catch it at all. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tUgv78fvmSAZUgD&open=AZr0_tUgv78fvmSAZUgD&pullRequest=1250

Check failure on line 27 in agent/post/document.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "/uploads/documents/" 6 times. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tNJv78fvmSAZUfn&open=AZr0_tNJv78fvmSAZUfn&pullRequest=1250

Check warning on line 575 in agent/files_legacy.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "require" with "require_once". 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tNiv78fvmSAZUfy&open=AZr0_tNiv78fvmSAZUfy&pullRequest=1250

Check warning on line 228 in agent/document_details.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Anchors must have content and the content must be accessible by a screen reader. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tR9v78fvmSAZUf7&open=AZr0_tR9v78fvmSAZUf7&pullRequest=1250

Check warning on line 367 in agent/files_legacy.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Anchor tags should not be used as buttons. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tNiv78fvmSAZUfq&open=AZr0_tNiv78fvmSAZUfq&pullRequest=1250

Check warning on line 347 in agent/files_legacy.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Anchor tags should not be used as buttons. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tNiv78fvmSAZUfp&open=AZr0_tNiv78fvmSAZUfp&pullRequest=1250

Check warning on line 546 in agent/files_legacy.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Anchor tags should not be used as buttons. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tNiv78fvmSAZUfs&open=AZr0_tNiv78fvmSAZUfs&pullRequest=1250

Check warning on line 874 in agent/files.php

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tQav78fvmSAZUf4&open=AZr0_tQav78fvmSAZUf4&pullRequest=1250

Check warning on line 78 in js/bulk_actions.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=itflow-org_itflow&issues=AZr0_tUgv78fvmSAZUgC&open=AZr0_tUgv78fvmSAZUgC&pullRequest=1250
View more details on SonarQubeCloud