Develop Branch PR: Bug-fix: Nested Modals fix#1252
Develop Branch PR: Bug-fix: Nested Modals fix#1252RyanSawyer6003 wants to merge 2 commits intoitflow-org:developfrom
Conversation
Added fix for nested modals closing parent modals
Previous Commit didn't correct issue with nested modals. This commit changes how modals are created to put each one in it's own unique container so that closing a nested modal does not close the parent container
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello & Welcome! :)
Thanks for taking the time to help improve ITFlow. We're excited to review your contributions - we'll review this PR as soon as we can!
Whilst you're waiting, please feel free to check out the forum.
Just so you know, all contributions to ITFlow are licensed under the GNU GPL. By contributing you grant us a perpetual & irrevocable license to include your work in ITFlow.
|
|
Nevermind... I jumped the gun. This does work on closing nested modals, but not on saving new data. Closing PR will submit new when properly fixed. |
|
Your right you would almost have to refresh the parent model once the child modal submits so it can get any new data? |
2 participants
This PR fixed nested modal window behavior on close. Each modal now is in it's own container and parent modals are not closed on closing of child modals.