Total review by rasmusrim · Pull Request #1 · ithinn/todo-list

rasmusrim · 2020-12-14T18:20:21Z

No description provided.

rasmusrim

Mye fint her, Ida! Det jeg reagerer mest på, er en veldig blanding av engelsk/norsk i tillegg til mange ulike naming conventions. Jeg tenker at disse tre tingene er de første jeg ville gjort for å gjøre koden bedre:

Bli kvitt alt norsk. Skriv all kode på engelsk.
Bli enig med deg selv om èn naming convention når det gjelder variabler eller funksjoner og hold deg til den. CSS klassenavn har vanligvis kebabcase mens variabler og funksjoner i javascript har camel case.
Flytt alle string literals som brukes internt i systemet til variabler for å unngå skrivefeil. En skrivefeil på en variabel kaster en feilmelding, hvis du skriver "gavelist" i stedet for "gaveliste", risikerer du en feil som fort kan ta en god del tid å finne.

rasmusrim · 2020-12-14T18:21:34Z

README.old.md

@@ -0,0 +1 @@
+# overlev-jula


Denne fila burde vekk.

rasmusrim · 2020-12-14T18:21:59Z

.eslintcache

@@ -0,0 +1 @@
+[{"C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\Valgboks\\Valgboks.js":"1","C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\App.js":"2"},{"size":1191,"mtime":1606230139602,"results":"3","hashOfConfig":"4"},{"size":255,"mtime":1606229497451,"results":"5","hashOfConfig":"4"},{"filePath":"6","messages":"7","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"3vbqs4",{"filePath":"8","messages":"9","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\Valgboks\\Valgboks.js",[],"C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\App.js",[]]


Denne fila burde kanskje ikke blitt committa? Putt den i .gitignore

rasmusrim · 2020-12-14T18:23:41Z

.eslintcache

@@ -0,0 +1 @@
+[{"C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\Valgboks\\Valgboks.js":"1","C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\App.js":"2","C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\Header\\Header.js":"3","C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\Liste\\Liste.js":"4","C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\ListItem\\ListItem.js":"5","C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\index.js":"6","C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\reportWebVitals.js":"7","C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\Kalender\\Kalender.js":"8","C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\Dot\\Dot.js":"9","C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\Snow\\Snow.js":"10","C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\NavLinks\\NavLinks.js":"11","C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\ButtonX\\ButtonX.js":"12"},{"size":2720,"mtime":1607431194114,"results":"13","hashOfConfig":"14"},{"size":5946,"mtime":1607437346720,"results":"15","hashOfConfig":"14"},{"size":236,"mtime":1607438207608,"results":"16","hashOfConfig":"14"},{"size":1797,"mtime":1607440559666,"results":"17","hashOfConfig":"14"},{"size":1039,"mtime":1607440601930,"results":"18","hashOfConfig":"14"},{"size":560,"mtime":1607019456488,"results":"19","hashOfConfig":"14"},{"size":362,"mtime":499162500000,"results":"20","hashOfConfig":"14"},{"size":2105,"mtime":1607441049378,"results":"21","hashOfConfig":"14"},{"size":2152,"mtime":1607440514050,"results":"22","hashOfConfig":"14"},{"size":1126,"mtime":1607439441210,"results":"23","hashOfConfig":"14"},{"size":687,"mtime":1607439103962,"results":"24","hashOfConfig":"14"},{"size":440,"mtime":1607440522850,"results":"25","hashOfConfig":"14"},{"filePath":"26","messages":"27","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"3vbqs4",{"filePath":"28","messages":"29","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"30","messages":"31","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"32","messages":"33","errorCount":0,"warningCount":2,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"34","messages":"35","errorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"36","messages":"37","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"38"},{"filePath":"39","messages":"40","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"41","messages":"42","errorCount":0,"warningCount":2,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"43","messages":"44","errorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"45","messages":"46","errorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"47","messages":"48","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"49","messages":"50","errorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},"C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\Valgboks\\Valgboks.js",[],"C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\App.js",[],"C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\Header\\Header.js",[],"C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\Liste\\Liste.js",["51","52"],"C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\ListItem\\ListItem.js",["53"],"C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\index.js",[],["54","55"],"C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\reportWebVitals.js",[],"C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\Kalender\\Kalender.js",["56","57"],"C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\Dot\\Dot.js",["58"],"C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\Snow\\Snow.js",["59"],"C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\NavLinks\\NavLinks.js",[],"C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\ButtonX\\ButtonX.js",["60"],{"ruleId":"61","severity":1,"message":"62","line":10,"column":71,"nodeType":"63","messageId":"64","endLine":10,"endColumn":73},{"ruleId":"61","severity":1,"message":"62","line":22,"column":74,"nodeType":"63","messageId":"64","endLine":22,"endColumn":76},{"ruleId":"65","severity":1,"message":"66","line":15,"column":17,"nodeType":"67","messageId":"68","endLine":15,"endColumn":34},{"ruleId":"69","replacedBy":"70"},{"ruleId":"71","replacedBy":"72"},{"ruleId":"61","severity":1,"message":"62","line":23,"column":54,"nodeType":"63","messageId":"64","endLine":23,"endColumn":56},{"ruleId":"73","severity":1,"message":"74","line":32,"column":42,"nodeType":"75","messageId":"76","endLine":32,"endColumn":44},{"ruleId":"77","severity":1,"message":"78","line":1,"column":16,"nodeType":"79","messageId":"80","endLine":1,"endColumn":24},{"ruleId":"65","severity":1,"message":"66","line":14,"column":13,"nodeType":"67","messageId":"68","endLine":14,"endColumn":33},{"ruleId":"65","severity":1,"message":"66","line":8,"column":13,"nodeType":"67","messageId":"68","endLine":8,"endColumn":30},"array-callback-return","Array.prototype.map() expects a value to be returned at the end of arrow function.","ArrowFunctionExpression","expectedAtEnd","no-lone-blocks","Nested block is redundant.","BlockStatement","redundantNestedBlock","no-native-reassign",["81"],"no-negated-in-lhs",["82"],"eqeqeq","Expected '===' and instead saw '=='.","BinaryExpression","unexpected","no-unused-vars","'useState' is defined but never used.","Identifier","unusedVar","no-global-assign","no-unsafe-negation"]


Denne fila burde kanskje ikke være med i repo-et? Putt den i .gitignore.

rasmusrim · 2020-12-14T18:24:10Z

public/manifest.json

@@ -0,0 +1,25 @@
+{


rasmusrim · 2020-12-14T18:24:49Z

src/App.css

+  background-image: url("./img/korktavle.png");
+  background-position: cover;
+  overflow-x: hidden; 
+  font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', 'Roboto', 'Oxygen',


Det er bedre å pakke en font med websida i stedet for å liste opp 100 stykk og håpe at brukeren har en av dem...

rasmusrim · 2020-12-14T18:38:08Z

src/App.js

+  class Task {
+    constructor(oppgave, ansvar, frist, className) {
+      this.oppgave = oppgave;
+      this.ansvar = ansvar;
+      this.frist = Moment(frist).format("DD/MM");
+      this.className = className;
+      this.id = "key" + Math.floor(Math.random()*1000);
+    }
+  }


Fila App.js er veldig lang. Kanskje dette kunne tas ut i en egen fil?

rasmusrim · 2020-12-14T18:40:46Z

src/components/Dot/dot.css

+    background: rgb(20, 111, 163);
+}
+
+.praktiskdot {


Vær konsekvent med navgiving. Ikke bland "dot-info" og "gavedot". I CSS er kebab case vanligst "gave-dot".

rasmusrim · 2020-12-14T18:41:41Z

src/components/Kalender/Kalender.js

+
+    //Lister ut en div for hvert item i DESEMBER
+    //Går gjennom lista med oppgaver og oppretter en Dot-component inne i diven hvis fristen for oppgaven stemmer overens med index til diven. 
+    const DAGLISTE = DESEMBER.map((item, index) => 


Bruker .map. Flott!

rasmusrim · 2020-12-14T18:42:24Z

src/components/Kalender/Kalender.js

+                        const frist = dot.frist;
+
+                        //legger til 0 foran index mellom 0-9, slik at det stemmer overens med formatet på "littfrist"
+                        const datoformat = index < 10 ? "0" + index : index;


Sjekk ut padStart: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/padStart

rasmusrim · 2020-12-14T18:46:14Z

src/components/Liste/Liste.js

+
+              { props.isTasks ?
+
+                //Hvis isTasks er true legges ListItemene inn i listen


Denne kommentaren bør være overflødig. Dette bør man kunne skjønne gjennom å lese koden.

ithinn added 6 commits November 24, 2020 16:03

Første dag

933b235

c

5afe36a

dag 2

1b54c2d

Med første styling

053239b

etter finpuss

8e5da38

Siste versjon

5cf710d

rasmusrim self-assigned this Dec 14, 2020

rasmusrim commented Dec 14, 2020

View reviewed changes

Siste finpuss

a68ba8b

github-pages bot deployed to github-pages December 15, 2020 19:42 View deployment

github-pages bot deployed to github-pages April 7, 2021 13:10 View deployment

Update README.md

0de784f

github-pages bot deployed to github-pages April 7, 2021 13:11 View deployment

Update README.md

34d7b2b

github-pages bot deployed to github-pages May 5, 2021 15:07 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Total review#1

Total review#1
rasmusrim wants to merge 9 commits intoreview/total_reviewfrom
main

rasmusrim commented Dec 14, 2020

Uh oh!

rasmusrim left a comment

Uh oh!

rasmusrim Dec 14, 2020

Uh oh!

rasmusrim Dec 14, 2020

Uh oh!

rasmusrim Dec 14, 2020

Uh oh!

rasmusrim Dec 14, 2020

Uh oh!

rasmusrim Dec 14, 2020

Uh oh!

rasmusrim Dec 14, 2020

Uh oh!

rasmusrim Dec 14, 2020

Uh oh!

rasmusrim Dec 14, 2020

Uh oh!

rasmusrim Dec 14, 2020

Uh oh!

rasmusrim Dec 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1 @@
		[{"C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\Valgboks\\Valgboks.js":"1","C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\App.js":"2"},{"size":1191,"mtime":1606230139602,"results":"3","hashOfConfig":"4"},{"size":255,"mtime":1606229497451,"results":"5","hashOfConfig":"4"},{"filePath":"6","messages":"7","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"3vbqs4",{"filePath":"8","messages":"9","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\components\\Valgboks\\Valgboks.js",[],"C:\\Users\\47415\\Documents\\git-repositories\\overlev-jula1\\src\\App.js",[]] No newline at end of file


		{ props.isTasks ?

		//Hvis isTasks er true legges ListItemene inn i listen

Conversation

rasmusrim commented Dec 14, 2020

Uh oh!

rasmusrim left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants