Feature/version3 newbie friendly#2
Open
agnetemoos wants to merge 16 commits intoitk-dev:feature/version3from
Open
Feature/version3 newbie friendly#2agnetemoos wants to merge 16 commits intoitk-dev:feature/version3from
agnetemoos wants to merge 16 commits intoitk-dev:feature/version3from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additions and changes to make installation of OS2Display easy for newcomers.
Three use cases are in focus:
NOTE: Aarhus is welcome to add an
.env.aarhus.exampleor similar with sensible default values for your setup, if that can be of help to you.Notable changes:
About env vars
.env.example..env.exampleas the single source of information about configuration variables available.COMPOSE_FILESisdocker-compose.yml,docker-compose.mariadb.yml,docker-compose.traefik.yml.env:buildif no.envis present when runningtask install.env:buildhave changed.About Taskfile
task upgradeadded to make it easy to upgrade OS2Display.task install, added a check for SSL certificates if internal Traefik is configured in.env..env.exampleto be compatible, and there might be relevant tasks missing. I fear that the installation package is downloaded once during installation and never upgraded. The version check checks for major version changes. Can I assume that environment variables are not added, removed, or changed in minor versions?task uninstalladded. Uninstall is a useful feature when you are tinkering with the system and somehow screw things up. This helps you start over.task purge, filter out the--networkflag before passing to docker compose.Traefik reverse proxy
task installwith default options, Traefik is installed.