Fix layer detection regex to handle any XML attribute order - #6
Open
its-luca wants to merge 1 commit into
Open
Conversation
The old regex required drawio's mxCell attributes in a fixed order (id, value, parent) but drawio writes them as (id, parent, value), causing layer_count to always be 0 and default to 1. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<mxCell>attributes in the orderid,value,parent, but drawio actually writes them asid,parent,valuelayer_countto always be 0 (defaulting to 1), so only a single export step was produced even for files with multiple layers<mxCell\b[^>]*\bparent="."[^>]*/>matches any self-closingmxCellwith a single-character parent regardless of attribute orderTest plan
cargo testpasses🤖 Generated with Claude Code