Polish channels view: info bar, onboarding, full-width modulation#283
Merged
Polish channels view: info bar, onboarding, full-width modulation#283
Conversation
…th modulation 1. Remove centered title, controls are now the first row (ch-controls) 2. Add channel info bar showing current Power, SNR, DOCSIS version, frequency, and health status after channel selection 3. Add onboarding empty state with icon and guidance text (replaces blank page before channel selection) 4. Make modulation chart full-width (grid-column: 1/-1) to fill the unbalanced empty space 5. Extract inline styles to CSS classes 6. Add channel_onboarding_title/desc i18n keys in all 4 languages
- Separate onboarding (channel-empty) from error messages (channel-no-data) so textContent writes don't destroy the onboarding HTML - switchChannelMode shows pristine onboarding instead of overwriting it - Add marginal/critical health classes to CSS (backend uses these, not warn/crit)
- catch block now uses noDataEl instead of emptyEl (preserves onboarding) - Hide channel info bar when switching to compare mode - Add .warning health class (backend emits 'warning' not 'warn')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design critique follow-up for the Channels view.
Test plan