Skip to content

Fix modem URL reverting to default on settings page load #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itsDNNS merged 1 commit into from
Mar 24, 2026
Merged

Fix modem URL reverting to default on settings page load #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions app/static/js/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,15 +930,7 @@ function _createBrowseItem(label, targetPath, iconName, isMuted) {
}

/* ── Username Field Toggle + Modem Defaults (data-driven) ── */
var KNOWN_DEFAULT_URLS = (function() {
var urls = {};
if (typeof DRIVER_HINTS !== 'undefined') {
for (var k in DRIVER_HINTS) {
if (DRIVER_HINTS[k].default_url) urls[DRIVER_HINTS[k].default_url] = true;
}
}
return urls;
})();
var _previousDriverDefault = '';

function toggleUsernameField() {
var modemType = document.getElementById('modem_type');
Expand All @@ -957,10 +949,11 @@ function toggleUsernameField() {
var testBtnParent = testBtn ? testBtn.parentElement : null;
var testResult = document.getElementById('modem-test');

// URL default: apply if field is empty or still shows any known modem default
if (hints.default_url && urlField && (!urlField.value || KNOWN_DEFAULT_URLS[urlField.value])) {
// URL default: apply only if field is empty or shows the previous driver's default
if (hints.default_url && urlField && (!urlField.value || urlField.value === _previousDriverDefault)) {
urlField.value = hints.default_url;
}
_previousDriverDefault = hints.default_url || '';

if (hints.credentials_required === false) {
credFields.forEach(function(el) { if (el) el.style.display = 'none'; });
Expand Down