Open
Conversation
AvtoBBus
requested changes
Feb 28, 2026
Comment on lines
+9
to
+33
| function validateInput(input) { | ||
| let value = input.value.replace(/[^0-9.\-]/g, ''); | ||
|
|
||
| if (value.length > 0 && value[0] !== '-') { | ||
| value = value.replace(/\-/g, ''); | ||
| } else if (value.length > 1) { | ||
| value = '-' + value.substring(1).replace(/\-/g, ''); | ||
| } | ||
|
|
||
| const dots = value.match(/\./g); | ||
| if (dots && dots.length > 1) { | ||
| const parts = value.split('.'); | ||
| value = parts[0] + '.' + parts.slice(1).join('').replace(/\./g, ''); | ||
| } | ||
|
|
||
| if (/^[+*/]/.test(value)) { | ||
| value = value.substring(1); | ||
| } | ||
|
|
||
| if (value.startsWith('.')) { | ||
| value = '0' + value; | ||
| } | ||
|
|
||
| return value; | ||
| } |
Collaborator
There was a problem hiding this comment.
Это слишком сложно и не нужно, просто поставьте у input атрибут type="number"
Comment on lines
+3
to
+7
| const firstNumberInput = document.getElementById('firstNumber'); | ||
| const secondNumberInput = document.getElementById('secondNumber'); | ||
| const operatorSelect = document.getElementById('operator'); | ||
| const calculateBtn = document.getElementById('calculateBtn'); | ||
| const resultContainer = document.getElementById('resultContainer'); |
Collaborator
There was a problem hiding this comment.
Какой-то элемент может быть не найден (мало ли что произошло)
Comment on lines
+47
to
+52
| input.addEventListener('keypress', function(e) { | ||
| const char = String.fromCharCode(e.which); | ||
| if (!/[0-9.\-]/.test(char)) { | ||
| e.preventDefault(); | ||
| } | ||
| }); |
Collaborator
There was a problem hiding this comment.
Опять же лишние действия, просто тип number нужен
Comment on lines
+154
to
+160
| [firstNumberInput, secondNumberInput].forEach(input => { | ||
| input.addEventListener('keypress', function(e) { | ||
| if (e.key === 'Enter') { | ||
| calculate(); | ||
| } | ||
| }); | ||
| }); |
Collaborator
There was a problem hiding this comment.
Похожий код был выше, можно все назначения слушателей событий повесить в одном forEach
Comment on lines
+63
to
+80
| if (!firstValue && !secondValue) { | ||
| firstNumberInput.classList.add('error'); | ||
| secondNumberInput.classList.add('error'); | ||
| showError('Введите оба числа'); | ||
| return; | ||
| } | ||
|
|
||
| if (!firstValue) { | ||
| firstNumberInput.classList.add('error'); | ||
| showError('Введите первое число'); | ||
| return; | ||
| } | ||
|
|
||
| if (!secondValue) { | ||
| secondNumberInput.classList.add('error'); | ||
| showError('Введите второе число'); | ||
| return; | ||
| } |
Collaborator
There was a problem hiding this comment.
Можно упросить
if (!firstValue || !secondValue)
{
let errorText = `Введите ${!firstValue ? 'первое' : 'второе'} число`;
if (!firstValue && !secondValue)
errorText = 'Введите оба числа';
if (!firstValue) firstNumberInput.classList.add('error');
if (!secondValue) secondNumberInput.classList.add('error');
showError(errorText);
return
}
Comment on lines
+120
to
+121
| result = num1 / num2; | ||
| result = Math.round(result * 1000000) / 1000000; |
| } | ||
| } | ||
|
|
||
| html += `<div class="result-item success">${calculationHistory[calculationHistory.length - 1]}</div>`; |
Collaborator
There was a problem hiding this comment.
Скорее не success, а current
Comment on lines
+139
to
+149
| let html = ''; | ||
|
|
||
| if (calculationHistory.length > 1) { | ||
| for (let i = 0; i < calculationHistory.length - 1; i++) { | ||
| html += `<div class="result-item">${calculationHistory[i]}</div>`; | ||
| } | ||
| } | ||
|
|
||
| html += `<div class="result-item success">${calculationHistory[calculationHistory.length - 1]}</div>`; | ||
|
|
||
| resultContainer.innerHTML = html; |
Collaborator
There was a problem hiding this comment.
В целом и так хорошо, но лично я бы этот код написал бы так
resultContainer.innerHtml = calculationHistory.map((item, index) => {
const checkLast = index === calculationHistory.length - 1;
return `<div class="result-item ${checkLast ? 'current' : ''}">${item}</div>`
})
Comment on lines
+32
to
+34
| <div class="result-container" id="resultContainer"> | ||
| <div class="result-item" style="opacity: 0.5; font-style: italic;">Результат появится здесь</div> | ||
| </div> |
Collaborator
There was a problem hiding this comment.
Чтобы не писать inline-стили можно просто поменять класс
<div class="result-container" id="resultContainer">
<div class="result-container__placeholder">Результат появится здесь</div>
</div>.result-container__placeholder {
opacity: 0.5;
font-style: italic;
}
Comment on lines
+81
to
+90
| .operator-wrapper::after { | ||
| content: '▼'; | ||
| position: absolute; | ||
| right: 12px; | ||
| top: 50%; | ||
| transform: translateY(-50%); | ||
| color: #c95b5b; | ||
| font-size: 10px; | ||
| pointer-events: none; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.