Open
Conversation
AvtoBBus
requested changes
Feb 28, 2026
Comment on lines
+1
to
+5
| const elA = document.getElementById('a'); | ||
| const elB = document.getElementById('b'); | ||
| const elOp = document.getElementById('op'); | ||
| const elBtn = document.getElementById('calc'); | ||
| const elOut = document.getElementById('out'); |
Collaborator
There was a problem hiding this comment.
Какой-то из элементов может быть не найден
Comment on lines
+7
to
+19
| function normalizeNumberText(s) { | ||
| return String(s).trim().replace(',', '.'); | ||
| } | ||
|
|
||
| function isValidNumberText(s) { | ||
| const t = normalizeNumberText(s); | ||
| if (t.length === 0) return false; | ||
| return /^[-+]?(?:\d+(?:\.\d+)?|\.\d+)$/.test(t); | ||
| } | ||
|
|
||
| function parseNumber(s) { | ||
| return Number(normalizeNumberText(s)); | ||
| } |
Collaborator
There was a problem hiding this comment.
Вот это всё сжимается в один parseFloat, если у input-ов поставите type='number'
Comment on lines
+38
to
+39
| const s = String(x); | ||
| if (s.includes('e')) return x.toPrecision(12).replace(/\.?0+$/,''); |
Collaborator
There was a problem hiding this comment.
Думаю это слишком, хватит простого toFixed
Comment on lines
+93
to
+108
| @media (max-width: 520px) { | ||
| .row{ | ||
| flex-direction: column; | ||
| align-items: stretch; | ||
| gap: 14px; | ||
| } | ||
|
|
||
| .select{ | ||
| width: 92px; | ||
| align-self: center; | ||
| } | ||
|
|
||
| .btn{ | ||
| width: 220px; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Где-то на 600 пикселей начинает уже возникать проблемка с адаптивностью, в целом задание опциональное, так что выполнять или нет на ваше усмотрение
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.