Skip to content

Source Line Previewing#5

Open
Sythivo wants to merge 4 commits intoitsfrank:mainfrom
Sythivo:preview-lines
Open

Source Line Previewing#5
Sythivo wants to merge 4 commits intoitsfrank:mainfrom
Sythivo:preview-lines

Conversation

@Sythivo
Copy link

@Sythivo Sythivo commented Nov 29, 2024

Adds source line previews with line peaks on reported failures.

image

@itsfrank
Copy link
Owner

itsfrank commented Dec 3, 2024

Nifty! I think I personally would find this a bit noisy, so I would definitely not want this to be the default, however I have gotten other requests for more verbose output.

I think I need to figure out if I want to either:

  • Add an optional configuration object to lune_console_reporter's init function
  • Add other variant reporters

Right now I am extremely busy with the year ending and our final releases going out at work, but I will think on this and implement something later in december.

I think something like this would be a good way forward:

lune_console_reporter.init({
    peek_assertion_context = true,
    peek_context_range = 3,
})

The main inspiration for frktest was Catch2 which does show the assertion line, so I am really not against this, I just like how clean the current output is so I want to keep it as the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants