-
Notifications
You must be signed in to change notification settings - Fork 48
ci cd #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ci cd #132
Conversation
ec2a2cb to
cc9d034
Compare
|
check out runs on my fork:
p.s.: please fix windows compilation |
itsjunetime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally like this, and really do appreciate the work you've put into this. It's definitely something tdf would benefit from.
I'm not certain I like the tip-release workflow, so if you'd be able to explain it a bit more or what's useful about it, I'd appreciate it.
Also, I've obviously gotta figure out windows compilation. I don't have a windows machine, but I'll take a look at that and hopefully get it working soon.
| files: release-artifacts/* | ||
| prerelease: ${{ contains(github.ref, 'alpha') || contains(github.ref, 'beta') || contains(github.ref, 'rc') }} | ||
|
|
||
| tip-release: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand the usefulness or purpose of this workflow - does it just overwrite the tip tag with the latest commit every time a new commit is pushed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, there's a release, that's always updated on commits to main
eg:
Co-authored-by: June <61218022+itsjunetime@users.noreply.github.com>
Co-authored-by: June <61218022+itsjunetime@users.noreply.github.com>
|
Could you update the |
Co-authored-by: June <61218022+itsjunetime@users.noreply.github.com>
itsjunetime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was foolish again about the BMODE stuff, sorry - I'm hopeful that this should fix it, though.
Co-authored-by: June <61218022+itsjunetime@users.noreply.github.com>
Co-authored-by: June <61218022+itsjunetime@users.noreply.github.com>
fixes #10