Skip to content

bugfix: the label has xss bug #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lyon-liao wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bugfix: the label has xss bug #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/angular-pretty-checkable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ angular.module('pretty-checkable', [])
if(attrs.label!=='false'){
//set label text to label if available otherwise default to value
var labelText = scope.$eval(attrs.label ? attrs.label : attrs.value);
var label = angular.element('<label>'+labelText+'</label>');
var label = angular.element('<label></label>').text(labelText);

//add label before or after depending on label-left value
if(attrs.labelLeft){
Expand Down Expand Up @@ -122,7 +122,7 @@ angular.module('pretty-checkable', [])
if(attrs.label!=='false'){
//set label text to label if available otherwise default to value
var labelText = scope.$eval(attrs.label ? attrs.label : attrs.value);
var label = angular.element('<label>'+labelText+'</label>');
var label = angular.element('<label></label>').text(labelText);
//add label before or after depending on label-left value
if(attrs.labelLeft){
element.prepend(label);
Expand Down