Skip to content

feat: add includeIsolatedModules option#66

Merged
iurysza merged 4 commits intoiurysza:mainfrom
powlaa:feat/include-isolated-modules
Oct 14, 2025
Merged

feat: add includeIsolatedModules option#66
iurysza merged 4 commits intoiurysza:mainfrom
powlaa:feat/include-isolated-modules

Conversation

@powlaa
Copy link
Contributor

@powlaa powlaa commented Sep 18, 2025

🚀 Description

Adds includeIsolatedModules option (default: false) to the Module Graph plugin. When enabled, modules that have no dependencies or dependants will be shown as isolated Modules in the graph.

📄 Motivation and Context

Fixes #56. Adds flexibility to configure the output graph to optionally show modules without connections to other modules.

🧪 How Has This Been Tested?

  • Added unit tests for checking the new configuration behaviour
  • Tested with the sample project

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Haratsu
Copy link

Haratsu commented Sep 19, 2025

@iurysza is it possible that there is something wrong on the main branch?
I checked out the fork of @powlaa and ran tests on

  • mac,
  • ubuntu 24.04
  • as well as windows 11

but there all gradle builds succeed.

I currently cannot find a way to reproduce the pre merge checks error.
https://github.com/iurysza/module-graph/actions/runs/17820457334/job/50771638665?pr=66

@iurysza
Copy link
Owner

iurysza commented Sep 19, 2025

@Haratsu hmm, interesting. I haven't seen issues in the main branch.

I'll need to check this over the weekend when I'm back home.

@Haratsu
Copy link

Haratsu commented Sep 19, 2025

Thanks for your amazingly quick responses.
Also just locally build your main on each platform. without any issues in the tests.
So I assume some fancy edge case within the github action setup or our everydays nightmare some encoding issue 😉

Have a nice weekend

@Haratsu
Copy link

Haratsu commented Sep 23, 2025

Hello @iurysza,
Sorry for being a nuisance but did you have any further insight?

If you like we can have a RL-session in B. which is just ~2 hours from me.
I could provide a coworking space as well. 😁

@iurysza
Copy link
Owner

iurysza commented Sep 23, 2025

Hey @Haratsu , no problem! I can reproduce the failure locally.

Running ./gradlew preMerge fails on DigraphCodeBuilderTest. The issue seems to be that self-referential Gradle configuration dependencies (e.g., test classpaths) are being treated as isolated modules when includeIsolatedModules=true.

I'll try to push a fix for that. Sry for the delay.

Btw, are you in Berlin?

@Haratsu
Copy link

Haratsu commented Sep 23, 2025

@iurysza , Thanks for looking into it.

I'm located in Dresden, but i have access to an office in Berlin ;-)

@iurysza
Copy link
Owner

iurysza commented Sep 23, 2025

@Haratsu nice! It'd be nice hanging out is quite busy because of Droidcon Berlin. Berlindroid is planning something for tomorrow.

Btw, pushed the fix. Now gradlew validation check is complaining. I'll need to check it tomorrow.

@Haratsu
Copy link

Haratsu commented Sep 29, 2025

@iurysza , I hope you had a great weekend.
Did you have a chance last week to check whats wrong with gradle validation?

@Haratsu
Copy link

Haratsu commented Sep 29, 2025

@iurysza
I found the reason gradle wrapper validation action fails.

  • the action checks whether the checksum of the gradle-wrapper.jar matches the expected value for the version references in gradle-wrapper.properties
  • in commit bd23af7 you updated gradle-wrapper.properties but missed to update the gradle-wrapper.jar

@powlaa
Copy link
Contributor Author

powlaa commented Oct 13, 2025

Hey @iurysza,
I have updated the gradle-wrapper.jar to match the gradle-wrappers.properties version. Can you check if this fixed the issue please?

The old gradle/wrapper-validation-action@v1 has been deprecated
in favor of gradle/actions/wrapper-validation@v4
@iurysza iurysza merged commit 1eab5c9 into iurysza:main Oct 14, 2025
4 checks passed
@iurysza
Copy link
Owner

iurysza commented Oct 14, 2025

Sry for the massive delay @powlaa and @Haratsu. Apparently we needed to update the GH action too.
It's out now in v0.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include modules that have 0 dependencies and dependants in the output graph

3 participants