Skip to content

Adding infrastructure for validating vocabulary-controlled elements. - #4

Merged
at88mph merged 1 commit into
ivoa:mainfrom
msdemlei:add-vocabulary-validation
Jul 16, 2026
Merged

Adding infrastructure for validating vocabulary-controlled elements.#4
at88mph merged 1 commit into
ivoa:mainfrom
msdemlei:add-vocabulary-validation

Conversation

@msdemlei

@msdemlei msdemlei commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

This is basically an xslt-generating python script; see there for how to use it.

I've also added a file voc-exercise.vor in tests; this exercises the existing vocabulary checks. I have not added actual tests yet because I'm unsure about how single-resource validation should look like in the end.

This is basically an xslt-generating python script; see there for how
to use it.

I've also added a file voc-exercise.vor in tests; this exercises the
existing vocabulary checks.  I have not added actual tests yet because
I'm unsure about how single-resource validation should look like in
the end.

@at88mph at88mph left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit-pick.

# otherwise). mandatory is a flag saying whether vocabulary adherence
# is a must as opposed to a should.

# I'm leving the type of the root element open; should we enfoce

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos:

leaving
enforce

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take care of it actually, and add a test.

@at88mph
at88mph merged commit af2c96a into ivoa:main Jul 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants