Fix exception when etherscan responds no status#22
Open
qbonnard wants to merge 36 commits intoizetex:masterfrom
Open
Fix exception when etherscan responds no status#22qbonnard wants to merge 36 commits intoizetex:masterfrom
qbonnard wants to merge 36 commits intoizetex:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An exception is thrown if etherscan's json response does not include the
statusfield, e.g. onhttps://api.etherscan.io/api?module=proxy&action=eth_getTransactionByHash&txhash=0x087c822fc9b75bc4894df309cc18820f3d77659f0bc115a7035de39461a456a3
This PR first checks for the presence of the
statusfield before checking whether it's1Let me know if there is a better way to do this!