Conversation
…ure and documentation, migrating to Nix for environment management.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the project by externalizing all deployment-related infrastructure and processes. The changes remove the Docker build configuration, Docker Compose setup, Nginx configuration, and all associated deployment scripts and documentation. This move simplifies the repository by focusing solely on the application's core logic and development environment, delegating deployment concerns to an external meta-repository or system. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request performs a significant refactoring of the project's deployment strategy, removing all Docker Compose, Nginx, Certbot, and related deployment scripts. The documentation in GEMINI.md, README.md, and docs/LOCAL_DEV.md has been updated to reflect that deployment is now managed externally. Additionally, the google-cloud-sdk dependency has been removed from flake.nix. Feedback indicates that further documentation updates are needed across other docs/ files for consistency, and the removal of google-cloud-sdk might impact the scripts/import_journalism.py script, requiring attention to its gsutil dependency.
I am having trouble creating individual review comments. Click here to see my feedback.
README.md (9-11)
While you've correctly removed the deployment section from this README.md, several other documentation files still contain outdated deployment instructions and references to deleted files (like compose.prod.yaml and various deployment scripts). To ensure the documentation remains consistent, it would be beneficial to also update or remove the deployment-related content from other files as part of this refactoring.
Files with potentially outdated information include:
docs/AUTH_IMPLEMENTATION.mddocs/CACHING.mddocs/NIX_SETUP.md(still referencesgoogle-cloud-sdk)docs/SETUP_ADMIN.mddocs/timeout_fix_summary.md
flake.nix (61)
Removing google-cloud-sdk is consistent with the goal of this PR. However, this may break scripts/import_journalism.py, which uses gsutil to interact with Google Cloud Storage. If this script is still in use, its dependency on gsutil will need to be addressed, for example by documenting it as a required manual installation or finding an alternative.
There was a problem hiding this comment.
Pull request overview
This PR removes in-repo production deployment assets (scripts, Docker/Compose, Nginx config, and deployment docs), and updates a few developer-facing docs/configs to reflect that deployment is now handled elsewhere.
Changes:
- Deleted remote/prod deployment scripts and first-time infra/SSL helpers under
scripts/. - Removed production containerization/reverse-proxy assets (
Dockerfile,docker-compose.prod.yaml,nginx/nginx.conf) and deployment documentation. - Updated
flake.nix,README.md, andGEMINI.mdto drop/adjust deployment references.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/remote_setup.sh | Removed remote server setup script. |
| scripts/remote_build.sh | Removed remote build/restart orchestration script. |
| scripts/install_compose_plugin.sh | Removed Docker Compose installer helper. |
| scripts/init_ssl.sh | Removed first-time SSL initialization helper. |
| scripts/init_infra.sh | Removed GCP infra bootstrap script. |
| scripts/init_certbot.sh | Removed certbot bootstrap helper. |
| scripts/deploy.sh | Removed the main deployment entrypoint script. |
| nginx/nginx.conf | Removed in-repo Nginx reverse proxy configuration. |
| docker-compose.prod.yaml | Removed production Compose definition. |
| Dockerfile | Removed Docker build definition. |
| docs/deployment.md | Removed deployment guide (lowercase path). |
| docs/DEPLOYMENT.md | Removed deployment guide (uppercase path). |
| docs/LOCAL_DEV.md | Removed the “Production Deployment” section snippet. |
| flake.nix | Removed google-cloud-sdk from dev shell inputs. |
| README.md | Removed deployment section and adjusted architecture bullets. |
| GEMINI.md | Updated deployment ownership statement. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nd add a note on its concurrency limitations.
…tup instructions and script descriptions.
…ner tooling dependencies.
No description provided.