Skip to content

chore(No Story): Describe the security issue in the PR#30

Open
litao0515 wants to merge 1 commit into
j-kopf:mainfrom
litao0515:new
Open

chore(No Story): Describe the security issue in the PR#30
litao0515 wants to merge 1 commit into
j-kopf:mainfrom
litao0515:new

Conversation

@litao0515

@litao0515 litao0515 commented Feb 20, 2025

Copy link
Copy Markdown

What security problem did you see? (1-2 bullet points)

  1. All permission check should be moved to server side, along with any authentication
  2. Sensitive data such as API key and password and financial data should never be logged, printed or directly handled in application code
  3. Use atomic operation for financial data operation, such as db locks
  4. Alway valid any user input
  5. config should not have plain text secret
  6. printing stacktrace is dangerous

What solution does your PR suggest? (1-2 bullet points)

See comment

How can we verify this solution? (1-2 bullet points)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant