Conversation
|
Thanks for the PR and the plugin setup, @AlliotTech! Few notes:
|
|
Thanks for the review and for pointing out the concern about supply‑chain risk. The asdf‑prek plugin repository is a standard asdf plugin, maintained publicly on GitHub so that users can install via the usual asdf plugin add … steps. Regarding the supply‑chain concern: Authenticity/visibilityThe asdf‑prek repo is fully public — all code is visible and reviewable before anyone pulls it. There is no closed binary or opaque build step — users can inspect it and verify the install script before using it. Minimal scopeThe plugin is essentially a wrapper to fetch releases of prek itself, not arbitrary third‑party code. All it does is support the official release artifacts and the documented install steps. Upstream/ownership optionsIf preferred, we can move the plugin into an organization‑controlled namespace (e.g., under j178 or the official prek org) so that the hosting is aligned with upstream and reduces trust concerns. We can additionally add a note in the docs recommending users verify the plugin repository’s commit history, its SHA sums, and point them to the official upstream releases — the same best practices used for any install helper script. If you have specific requirements (e.g., signing the plugin, aligning with a canonical repo, or stricter vetting steps), I’m happy to address those. Would you prefer the plugin repository to be relocated under the j178/prek namespace before merging? |
feat: add asdf install method
asdf plugin repo: https://github.com/AlliotTech/asdf-prek
related pr: asdf-vm/asdf-plugins#1145