Skip to content

Document asdf installation method#1614

Draft
AlliotTech wants to merge 5 commits intoj178:masterfrom
AlliotTech:patch-1
Draft

Document asdf installation method#1614
AlliotTech wants to merge 5 commits intoj178:masterfrom
AlliotTech:patch-1

Conversation

@AlliotTech
Copy link

feat: add asdf install method

asdf plugin repo: https://github.com/AlliotTech/asdf-prek
related pr: asdf-vm/asdf-plugins#1145

@AlliotTech AlliotTech requested a review from j178 as a code owner February 9, 2026 14:37
@shaanmajid shaanmajid added the documentation Improvements or additions to documentation label Feb 9, 2026
@shaanmajid shaanmajid changed the title feat: add asdf install Document asdf installation method Feb 9, 2026
@shaanmajid shaanmajid marked this pull request as draft February 9, 2026 23:18
@shaanmajid
Copy link
Collaborator

Thanks for the PR and the plugin setup, @AlliotTech!

Few notes:

  1. Switched to draft status while waiting for upstream
  2. I'm a bit concerned about the possibility of a supply-chain attack with keeping the plugin in a third-party repo.

@AlliotTech
Copy link
Author

AlliotTech commented Feb 9, 2026

Thanks for the review and for pointing out the concern about supply‑chain risk.

The asdf‑prek plugin repository is a standard asdf plugin, maintained publicly on GitHub so that users can install via the usual asdf plugin add … steps.

Regarding the supply‑chain concern:

Authenticity/visibility

The asdf‑prek repo is fully public — all code is visible and reviewable before anyone pulls it. There is no closed binary or opaque build step — users can inspect it and verify the install script before using it.

Minimal scope

The plugin is essentially a wrapper to fetch releases of prek itself, not arbitrary third‑party code. All it does is support the official release artifacts and the documented install steps.

Upstream/ownership options

If preferred, we can move the plugin into an organization‑controlled namespace (e.g., under j178 or the official prek org) so that the hosting is aligned with upstream and reduces trust concerns.
Security practices

We can additionally add a note in the docs recommending users verify the plugin repository’s commit history, its SHA sums, and point them to the official upstream releases — the same best practices used for any install helper script.

If you have specific requirements (e.g., signing the plugin, aligning with a canonical repo, or stricter vetting steps), I’m happy to address those.

Would you prefer the plugin repository to be relocated under the j178/prek namespace before merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants