[FEATURE] Now duplicate field supports nearly all relations#20
Open
vahidRP wants to merge 1 commit intojackabox:masterfrom
Open
[FEATURE] Now duplicate field supports nearly all relations#20vahidRP wants to merge 1 commit intojackabox:masterfrom
vahidRP wants to merge 1 commit intojackabox:masterfrom
Conversation
jackabox
reviewed
Sep 3, 2019
| switch(get_class($relation_data)){ | ||
| case BelongsToMany::class: | ||
| case MorphToMany::class: | ||
| foreach ($items as $item) { |
Owner
There was a problem hiding this comment.
Probably want to extract these to individual functions to clean up this, when all classes are added it could become hard to read/manage.
Author
There was a problem hiding this comment.
As you wish. I think you can merge this changes to this currently version of your repository.
Owner
There was a problem hiding this comment.
Seems good, I'll give it a test and double-check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I improved DuplicateController by adding a switch on different relations and handled almost all relations.