Conversation
redloaf
approved these changes
Apr 25, 2025
Comment on lines
+547
to
+549
| if num <= 0 { | ||
| panic("aquireSemAll: num <= 0") | ||
| } |
There was a problem hiding this comment.
This is a slight behavior change but is more predictable. If num is negative, sem.TryAcquire can succeed and has the same effect as sem.Release(-num). However, it fails if there are any blocked Acquire calls. Before your changes, this has the potential to result in a sporadic panic for a condition that should probably always result in a panic (as you've written it).
Owner
|
LGTM. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #36
This change removes the last usage of
unsafefrom the package, which was used in a custom log2 implementation duringacquireSemAll. This can be implemented usingbits.Len64instead, provided the number >0. Since the method is internal, a panic in place seems a sensible response to violating that expectation.