Input/Output dir options#248
Open
denizzzka wants to merge 3 commits into
Open
Conversation
jacob-carlborg
requested changes
Jan 16, 2020
jacob-carlborg
left a comment
jacob-carlborg
left a comment
Owner
There was a problem hiding this comment.
Please include tests and a changelog entry.
| string outputPath; | ||
|
|
||
| /// in case there are many input files or dir output option provided | ||
| bool isOutputToDir; |
Owner
There was a problem hiding this comment.
Is the intention that both -O and -o are specified since this is a bool?
Author
I could not do this so that there were a minimum number of changes. |
Author
|
I run it by this way: |
Owner
I’m not sure I follow. You can have a look here at how to to implement a test: https://github.com/jacob-carlborg/dstep/blob/master/tests/functional/Tests.d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #243