Fix incorrect spelling collision for struct typedef#297
Open
davispuh wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a false-positive spelling collision warning when a struct’s translated name matches a typedef symbol that actually aliases the same underlying struct (common when translating headers that include other headers).
Changes:
- Adjusts collision detection in
Context.translateTagSpellingto ignore collisions when the “colliding” symbol resolves to the same underlying cursor.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Owner
|
I think the code review from Copilot is reasonable. |
Moved from IncludeGraphTests.d
This fixes case when we have 2 files:
```c
typedef struct {
int a;
} B;
```
And
```c
#include "first.h";
typedef B C;
```
Author
|
Improved PR and added tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider a case where we have 2 files:
first.hAnd
second.hThen currently trying to convert
second.hwe get warning:This is not correct, because
typedef B CmeansCis alias toBand it's not a collision.This PR fixes this issue.