Fix `-include` header when known modules are used by davispuh · Pull Request #298 · jacob-carlborg/dstep

davispuh · 2026-03-18T22:36:59Z

Currently if you have
a.h with:

#include <errno.h>

And empty b.h.
Then -include fails:

$ dstep -includeb.h a.h
dstep: an unknown error occurred: core.exception.RangeError@dstep/translator/HeaderIndex.d(100): Range violation
----------------
??:? onRangeError [0x55ba460de15a]
??:? _d_arraybounds [0x55ba460c4d15]
dstep/translator/HeaderIndex.d:100 bool dstep.translator.HeaderIndex.IncludeGraph.isReachableBy(immutable(char)[], immutable(char)[]) [0x55ba4606bf29]
dstep/translator/HeaderIndex.d:382 immutable(char)[][immutable(char)[]] dstep.translator.HeaderIndex.HeaderIndex.resolveKnownModules!(std.algorithm.iteration.FilterResult!(dstep.translator.HeaderIndex.HeaderIndex.__ctor(clang.TranslationUnit.TranslationUnit, const(immutable(char)[][immutable(char)[]])).__lambda_L308_C9, clang.Cursor.Cursor[]).FilterResult).resolveKnownModules(std.algorithm.iteration.FilterResult!(dstep.translator.HeaderIndex.HeaderIndex.__ctor(clang.TranslationUnit.TranslationUnit, const(immutable(char)[][immutable(char)[]])).__lambda_L308_C9, clang.Cursor.Cursor[]).FilterResult, dstep.translator.HeaderIndex.HeaderIndex.KnownModule[]) [0x55ba4606f0b7]
dstep/translator/HeaderIndex.d:323 dstep.translator.HeaderIndex.HeaderIndex dstep.translator.HeaderIndex.HeaderIndex.__ctor!(std.algorithm.iteration.FilterResult!(dstep.translator.HeaderIndex.HeaderIndex.__ctor(clang.TranslationUnit.TranslationUnit, const(immutable(char)[][immutable(char)[]])).__lambda_L308_C9, clang.Cursor.Cursor[]).FilterResult).__ctor(std.algorithm.iteration.FilterResult!(dstep.translator.HeaderIndex.HeaderIndex.__ctor(clang.TranslationUnit.TranslationUnit, const(immutable(char)[][immutable(char)[]])).__lambda_L308_C9, clang.Cursor.Cursor[]).FilterResult, const(immutable(char)[][immutable(char)[]])) [0x55ba4606ee48]
dstep/translator/HeaderIndex.d:316 dstep.translator.HeaderIndex.HeaderIndex dstep.translator.HeaderIndex.HeaderIndex.__ctor(clang.TranslationUnit.TranslationUnit, const(immutable(char)[][immutable(char)[]])) [0x55ba4606da89]
dstep/translator/HeaderIndex.d:293 dstep.translator.HeaderIndex.HeaderIndex dstep.translator.HeaderIndex.HeaderIndex.__ctor(clang.TranslationUnit.TranslationUnit) [0x55ba4606d95d]
dstep/translator/Context.d:158 dstep.translator.HeaderIndex.HeaderIndex dstep.translator.Context.Context.headerIndex() [0x55ba4606724a]
dstep/translator/Context.d:51 dstep.translator.Context.Context dstep.translator.Context.Context.__ctor(clang.TranslationUnit.TranslationUnit, dstep.translator.Options.Options, dstep.translator.Translator.Translator) [0x55ba46066c67]
dstep/translator/Translator.d:70 dstep.translator.Translator.Translator dstep.translator.Translator.Translator.__ctor(clang.TranslationUnit.TranslationUnit, dstep.translator.Options.Options) [0x55ba460ab587]
dstep/driver/Application.d:65 void dstep.driver.Application.Application.run() [0x55ba46052147]
dstep/driver/CommandLine.d:181 int dstep.driver.CommandLine.run(immutable(char)[][]) [0x55ba46062a61]
dstep/main.d:18 _Dmain [0x55ba46065977]
core.exception.RangeError@dstep/translator/HeaderIndex.d(100): Range violation
----------------
??:? onRangeError [0x55ba460de15a]
??:? _d_arraybounds [0x55ba460c4d15]
dstep/translator/HeaderIndex.d:100 bool dstep.translator.HeaderIndex.IncludeGraph.isReachableBy(immutable(char)[], immutable(char)[]) [0x55ba4606bf29]
dstep/translator/HeaderIndex.d:382 immutable(char)[][immutable(char)[]] dstep.translator.HeaderIndex.HeaderIndex.resolveKnownModules!(std.algorithm.iteration.FilterResult!(dstep.translator.HeaderIndex.HeaderIndex.__ctor(clang.TranslationUnit.TranslationUnit, const(immutable(char)[][immutable(char)[]])).__lambda_L308_C9, clang.Cursor.Cursor[]).FilterResult).resolveKnownModules(std.algorithm.iteration.FilterResult!(dstep.translator.HeaderIndex.HeaderIndex.__ctor(clang.TranslationUnit.TranslationUnit, const(immutable(char)[][immutable(char)[]])).__lambda_L308_C9, clang.Cursor.Cursor[]).FilterResult, dstep.translator.HeaderIndex.HeaderIndex.KnownModule[]) [0x55ba4606f0b7]
dstep/translator/HeaderIndex.d:323 dstep.translator.HeaderIndex.HeaderIndex dstep.translator.HeaderIndex.HeaderIndex.__ctor!(std.algorithm.iteration.FilterResult!(dstep.translator.HeaderIndex.HeaderIndex.__ctor(clang.TranslationUnit.TranslationUnit, const(immutable(char)[][immutable(char)[]])).__lambda_L308_C9, clang.Cursor.Cursor[]).FilterResult).__ctor(std.algorithm.iteration.FilterResult!(dstep.translator.HeaderIndex.HeaderIndex.__ctor(clang.TranslationUnit.TranslationUnit, const(immutable(char)[][immutable(char)[]])).__lambda_L308_C9, clang.Cursor.Cursor[]).FilterResult, const(immutable(char)[][immutable(char)[]])) [0x55ba4606ee48]
dstep/translator/HeaderIndex.d:316 dstep.translator.HeaderIndex.HeaderIndex dstep.translator.HeaderIndex.HeaderIndex.__ctor(clang.TranslationUnit.TranslationUnit, const(immutable(char)[][immutable(char)[]])) [0x55ba4606da89]
dstep/translator/HeaderIndex.d:293 dstep.translator.HeaderIndex.HeaderIndex dstep.translator.HeaderIndex.HeaderIndex.__ctor(clang.TranslationUnit.TranslationUnit) [0x55ba4606d95d]
dstep/translator/Context.d:158 dstep.translator.HeaderIndex.HeaderIndex dstep.translator.Context.Context.headerIndex() [0x55ba4606724a]
dstep/translator/Context.d:51 dstep.translator.Context.Context dstep.translator.Context.Context.__ctor(clang.TranslationUnit.TranslationUnit, dstep.translator.Options.Options, dstep.translator.Translator.Translator) [0x55ba46066c67]
dstep/translator/Translator.d:70 dstep.translator.Translator.Translator dstep.translator.Translator.Translator.__ctor(clang.TranslationUnit.TranslationUnit, dstep.translator.Options.Options) [0x55ba460ab587]
dstep/driver/Application.d:65 void dstep.driver.Application.Application.run() [0x55ba46052147]
dstep/driver/CommandLine.d:181 int dstep.driver.CommandLine.run(immutable(char)[][]) [0x55ba46062a61]
dstep/main.d:18 _Dmain [0x55ba46065977]

This PR fixes it so that it works.

Copilot

Pull request overview

Fixes a crash in dstep when compiling with -include and using known-module resolution, by ensuring headers introduced via directives with an empty including-file path are still indexed in the include graph.

Changes:

Extend IncludeGraph construction to register includedPath even when directive.file.absolutePath is empty (e.g., -include-injected headers).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

jacob-carlborg

Please add a test case as suggested.

Currently if you have a.h with: ``` #include <errno.h> ``` And empty `b.h` then `-include` fails: ``` $ dstep -includeb.h a.h dstep: an unknown error occurred: core.exception.RangeError@dstep/translator/HeaderIndex.d(100): Range violation ``` This commit fixes this issue.

davispuh · 2026-06-23T16:28:15Z

Added test.

Copilot AI review requested due to automatic review settings March 18, 2026 22:37

Copilot AI reviewed Mar 18, 2026

View reviewed changes

Comment thread dstep/translator/HeaderIndex.d

jacob-carlborg requested changes Mar 19, 2026

View reviewed changes

davispuh force-pushed the include branch from c6d46f7 to d87bfe2 Compare June 23, 2026 16:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `-include` header when known modules are used#298

Fix `-include` header when known modules are used#298
davispuh wants to merge 1 commit into
jacob-carlborg:masterfrom
davispuh:include

davispuh commented Mar 18, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

jacob-carlborg left a comment

Uh oh!

davispuh commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

davispuh commented Mar 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

jacob-carlborg left a comment

Choose a reason for hiding this comment

Uh oh!

davispuh commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants