Fix extern (C) header case#300
Open
davispuh wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes an output-ordering issue where module/imports could be inserted in the middle of the extern (C): line (e.g., producing extmodule / ern (C):) by restructuring how the translator builds the final Output.
Changes:
- Split translation output into a separate
contentOutput, then prependmodule/imports/externbefore merging. - Simplify
translateToString()to return theOutput’s header + content directly (removing the extraheadoutput buffer).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Currently if you have `a.h` like: ``` /** * comment with trailing whitespace * **/ #pragma once #define A 1 ``` And you run `dstep --package a --global-import b a.h` You will get broken code (note split extern): ``` /** * comment with trailing whitespace * **/ extmodule a.a; import b; ern (C): enum A = 1; ``` This commit fixes this issue.
Author
|
Rewrote this PR and added tests. First commit fixes original issue. 2nd is additional improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you have
a.hlike:And you run
dstep --package a --global-import b a.hThen result will be broken code (note split
extern):This PR fixes that so it will be correct code: