Support &=, ^=, |= for macros#307
Open
davispuh wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the macro expression parser so macros using compound bitwise-assignment operators (&=, ^=, |=) are no longer dropped and can be translated into equivalent D expressions.
Changes:
- Added parsing support for
&=,^=, and|=in macro expressions. - Routed conditional-expression parsing through the new compound-assignment parse layer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
I fixed operator precedence and added tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider macro like this:
Currently such macros with
&=,^=and|=are dropped.So this PR implements support for them and will produce D code like: