Correct the findings count, the cut table, and DELPHI's place in the portfolio - #15
Merged
Merged
Conversation
…portfolio Three things a reviewer meets early and none of them were right. The README headed four numbered findings 'The three findings'. Q13's negative was added as a fourth and the heading was not. docs/ROADMAP.md carried a blank line inside the 'Cut, and why' table, which ends a table in GitHub-flavoured markdown: M18, M19 and M24 rendered as literal pipe-delimited text rather than rows, so the three cuts that most need explaining were the three that did not render. The four sibling repositories cross-reference each other and none of them names DELPHI, so the newest project sat outside the portfolio it belongs to. It now states the relationship and, more usefully, the distinction: those four are detection systems, this one is a decision system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three things a reviewer meets early, none of them right.
The README headed four numbered findings "The three findings" — Q13's negative was added as a fourth and the heading was not.
docs/ROADMAP.mdcarried a blank line inside the "Cut, and why" table, which ends a table in GitHub-flavoured markdown. M18, M19 and M24 rendered as literal pipe-delimited text rather than rows, so the three cuts that most need explaining were the three that did not render.The four sibling repositories cross-reference each other and none named DELPHI. It now states the relationship and the distinction: those four are detection systems, this one is a decision system.