test(contract): lock demo handoff contract - #7
Merged
Conversation
Add the checked-in demo export package for the implemented FieldOps date range. Tested: uv run clean-data-export-api export jobs --from-date 2026-06-01 --to-date 2026-06-05 --output-dir outputs --database-path outputs/run_history.sqlite3 --page-size 4
Update public documentation from planned status to the implemented local workflow, including current counts, output files, and API request boundaries. Tested: uv run pytest tests/test_demo_contract.py tests/test_docs_contract.py -v Tested: rg "Planned|planned|not started|future CLI|future API|production-ready|enterprise security|guaranteed revenue|guaranteed ROI|output_dir" README.md docs
Add regression coverage for demo counts, output columns, rejected reason codes, current README commands, and public documentation boundaries. Tested: uv run pytest tests/test_demo_contract.py tests/test_docs_contract.py -v Tested: uv run pytest -v Tested: uv run pytest --cov=clean_data_export_api --cov-report=term-missing --cov-fail-under=90
Set CSV report line endings explicitly and lock checked-in demo outputs against fresh generated files. Also tighten current-status wording and public documentation wording guards. Tested: uv run pytest tests/test_demo_contract.py tests/test_docs_contract.py -v Tested: uv run ruff check . Tested: uv run ruff format --check . Tested: uv run basedpyright Tested: uv run pytest -v Tested: uv run pytest --cov=clean_data_export_api --cov-report=term-missing --cov-fail-under=90 Tested: uv run python -m compileall src tests
Remove brittle documentation text assertions and keep the checked-in demo artifact contract test as the regression guard. Extract a shared job export candidate factory so validation and duplicate handling tests do not carry copy-pasted fixtures. Tested: - uv run ruff check . - uv run ruff format --check . - uv run basedpyright - uv run pytest -v - uv run pytest --cov=clean_data_export_api --cov-report=term-missing --cov-fail-under=90 - uv run python -m compileall src tests - git diff --check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan