Improved support for Launchpad Pro MK3#21
Open
Xpktro wants to merge 2 commits into
Open
Conversation
Owner
|
Hi, If you still care about this, please create a new supported device file for the LP pro MK3 rather than modifying launchpad_rgb. |
|
Recently acquired a LP Pro MK3, will rework the PR, thanks for the insights @jaggednz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently bought a Launchpad Pro MK3 as the Readme stated it was supported. Was puzzled when it didn't work automagically at first. I discovered two things:
Launchpad Pro MK3 1in the MIDI devices list, but the mapping was expecting a non-numbered name.This PR addresses both situations detecting numbered Launchpad MK3 names and setting the appropriate init Programmer Mode message.