make ComparableExpressions sortable#1455
Open
gavinking wants to merge 1 commit into
Open
Conversation
gavinking
commented
May 20, 2026
Comment on lines
+223
to
224
| @Deprecated(since = "1.1", forRemoval = true) | ||
| public Sort(String property, boolean isAscending, boolean ignoreCase) { |
gavinking
commented
May 20, 2026
Comment on lines
-91
to
+86
| public record Sort<T>(String property, | ||
| boolean isAscending, | ||
| boolean ignoreCase, | ||
| Nulls nullOrdering) { | ||
| public final class Sort<T> { |
njr-11
reviewed
May 20, 2026
Member
njr-11
left a comment
njr-11
left a comment
There was a problem hiding this comment.
I'd rather not introduce Sortable. It doesn't do anything useful for the end user and I don't think we need it. I wanted to try out adding the asc/desc methods to ComparableExpression and the ascIgnoreCase/descIgnoreCase methods to TextExpression. This seems to work fine in a commit of 1400 where I tried it out. I created a couple of new unit tests to verify it as well as updating the test that were previously under 1400 so they test navigable expressions rather than navigable attributes. That all seemed to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This had a bigger impact than I expected.
Question: do we need
SortableExpression?