This repository was archived by the owner on Jul 12, 2022. It is now read-only.
Add custom transpiler to fix 'failed to load package' issue#47
Open
smhxx wants to merge 2 commits intojakesankey:masterfrom
Open
Add custom transpiler to fix 'failed to load package' issue#47smhxx wants to merge 2 commits intojakesankey:masterfrom
smhxx wants to merge 2 commits intojakesankey:masterfrom
Conversation
This patch adds atom-ts-transpiler and TypeScript as dependenies, circumventing the issues that have been occuring in recent versions of Atom where TypeScript source files would fail to be loaded. Closes jakesankey#45, jakesankey#46.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a fixed version of #46 that implements the pending requested changes, and should resolve the build errors which have been occurring on that PR. Given the number of users who appear to be waiting for #45 to be resolved, a new patch version should probably be pushed out when possible. To be honest, this solution feels a bit "heavy-weight" for a package this small, but it's also the fastest way to fix it without modifying the existing code-base.
/cc @jakesankey