Implement postcard_schema::Schema for VecDeque, Rc, and Arc#277
Open
Calsign wants to merge 3 commits intojamesmunns:mainfrom
Open
Implement postcard_schema::Schema for VecDeque, Rc, and Arc#277Calsign wants to merge 3 commits intojamesmunns:mainfrom
postcard_schema::Schema for VecDeque, Rc, and Arc#277Calsign wants to merge 3 commits intojamesmunns:mainfrom
Conversation
✅ Deploy Preview for cute-starship-2d9c9b canceled.
|
It's not present on all systems, as evidenced by the CI check for RISC-V. it's possible it can be added back with the right cfg flags.
Calsign
force-pushed
the
postcard-dyn-impl-vec-deque-arc-rc
branch
from
ff2c656 to
f8a0451
Compare
✅ Deploy Preview for cute-starship-2d9c9b canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are standard library types so I assume they are uncontroversial. I followed the existing conventions for these types.
(Side question: I understand the postcard-schema/postcard-schema-dyn split, but why do we need to implement the same schemas for both alloc and std, why can't std reuse the alloc implementations?)