Integrate selected UX, search, and theming improvements from PR #127#128
Draft
jamesrochabrun wants to merge 12 commits intomainfrom
Draft
Integrate selected UX, search, and theming improvements from PR #127#128jamesrochabrun wants to merge 12 commits intomainfrom
jamesrochabrun wants to merge 12 commits intomainfrom
Conversation
de50d9c to
c957a1e
Compare
Introduce debounced search to avoid blocking on every keystroke, cache compiled regex patterns for reuse, and fix NLEmbedding access to use a dedicated actor for thread safety.
Wrap the side panel ScrollView in a ScrollViewReader and use a dedicated scrollToSessionId state to animate the selected row into view when navigating via Cmd+K.
Reset selectedIndex to the first session result when the query is active, so the highlight doesn't jump to an unrelated quick-action after debounced results arrive.
Wrap the list/grid ScrollView in ScrollViewReader and watch primarySessionId to auto-scroll the monitoring panel when a session is selected from the side panel or Cmd+K search. Adds .id(item.id) to each MonitoringCardView so ScrollViewReader can locate them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
This PR now includes a curated integration of selected work from contributor PR #127, aligned with AgentHub's current UX and architecture.
Integrated from #127
Alignment Work
Validation
Thanks again to the contributor for the original implementation work that enabled this integration path.