Fix mask parameter for ImageEdit request#132
Open
glyuck wants to merge 2 commits intojamesrochabrun:mainfrom
Open
Fix mask parameter for ImageEdit request#132glyuck wants to merge 2 commits intojamesrochabrun:mainfrom
mask parameter for ImageEdit request#132glyuck wants to merge 2 commits intojamesrochabrun:mainfrom
Conversation
`mask` parameter should be file, also it can be nil
Owner
|
hello thanks for contributing, the PR description is a bit confusing compared to all the code on the PR, what is the bug we are solving with this changes? |
b488eae to
769dcf9
Compare
Contributor
Author
|
Sorry – I accidentally added an extra commit to the PR, but it's been removed now.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maskparameter should be sent as afile(instead of astring).It can also be
nil, so don't throw an assertion error in that case.