Skip to content
This repository was archived by the owner on Nov 2, 2022. It is now read-only.

Extract request object#52

Open
tangrufus wants to merge 1 commit intojamesryanbell:masterfrom
tangrufus:extract-request-object
Open

Extract request object#52
tangrufus wants to merge 1 commit intojamesryanbell:masterfrom
tangrufus:extract-request-object

Conversation

@tangrufus
Copy link
Contributor

@tangrufus tangrufus commented Feb 26, 2017

  • Extract request object while keeping backward compatibility.
  • Lock phpunit version below 6

Usage:

namespace Cloudflare;

$api = new Api();
$request = new Request();
$api->setRequest($request);

stickler-ci
stickler-ci reviewed Feb 26, 2017
View reviewed changes
src/CloudFlare/Request.php Outdated

return $response;
}
} No newline at end of file
Copy link

@stickler-ci stickler-ci Feb 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected 1 newline at end of file; 0 found

Copy link
Contributor Author

@tangrufus tangrufus Feb 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

stickler-ci
stickler-ci reviewed Feb 26, 2017
View reviewed changes
src/CloudFlare/RequestInterface.php Outdated
* @return mixed
*/
public function perform($api, $path, array $data = null, $method = null);
} No newline at end of file
Copy link

@stickler-ci stickler-ci Feb 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected 1 newline at end of file; 0 found

Copy link
Contributor Author

@tangrufus tangrufus Feb 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@tangrufus tangrufus force-pushed the extract-request-object branch from 46c0c76 to bd3209c Compare February 26, 2017 20:46
@coveralls
Copy link

coveralls commented Feb 26, 2017

Coverage Status

Coverage increased (+8.007%) to 11.349% when pulling bd3209c on TangRufus:extract-request-object into 5e38c90 on jamesryanbell:master.

2 similar comments
@coveralls
Copy link

coveralls commented Feb 26, 2017

Coverage Status

Coverage increased (+8.007%) to 11.349% when pulling bd3209c on TangRufus:extract-request-object into 5e38c90 on jamesryanbell:master.

@coveralls
Copy link

coveralls commented Feb 26, 2017

Coverage Status

Coverage increased (+8.007%) to 11.349% when pulling bd3209c on TangRufus:extract-request-object into 5e38c90 on jamesryanbell:master.

@tangrufus tangrufus force-pushed the extract-request-object branch from bd3209c to 138fec7 Compare February 26, 2017 20:48
@tangrufus
Copy link
Contributor Author

tangrufus commented Feb 26, 2017

Style fixed and added php 7.1 to Travis matrix

@coveralls
Copy link

coveralls commented Feb 26, 2017 •
edited
Loading

Coverage Status

Coverage increased (+10.3%) to 13.614% when pulling 46c0c76 on TangRufus:extract-request-object into 5e38c90 on jamesryanbell:master.

@coveralls
Copy link

coveralls commented Feb 26, 2017 •
edited
Loading

Coverage Status

Coverage increased (+8.007%) to 11.349% when pulling 138fec7 on TangRufus:extract-request-object into 5e38c90 on jamesryanbell:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@stickler-ci stickler-ci stickler-ci left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tangrufus @coveralls @stickler-ci