Peer Review - Anthony Minnella

[salminnella]

1. Does the project appear to meet the technical requirements? Write up one sentence on your findings and give a score 0-3.
score = 1
no api calls or sdk's yet.

Is your peer making API calls, using SDK's/third-party libraries?
not at this time.

Is your peer making use of Services? If so, are they offloading long tasks to a separate thread, i.e. AsyncTask, Runnable, IntentService, etc.
not at this time

Is your peer making use of Fragments? If so, are they passing data from Fragment to Activity via interfaces? If not, why did absense of Fragments make sense?
not at this time.

Is your peer making use of RecyclerView? If so, does it appear to be working correctly ( implementation and otherwise )?
Yes, the recycler view is working correctly. Nice job on having the view holder class separate for reuse.

Is your peer making use of some sort of persistent storage, i.e. Firebase or SQLite? If so, why do you think Firebase/SQLite was chosen? Could they have used one or the other instead and why?
not implemented yet, but sharing recipes could be useful in firebase.

2. Does the project appear to be creative, innovative, and different from any competition? Write up one sentence on your findings and give a score 0-3.
score = 3
yes, the idea of flipping a card to see the recipe under the picture seems newer then some other recipe apps

Is your peer making use of proper UX patterns we learned in class? If not, what are they doing that is unconvetional or that might confuse a user ( you )?
the recycler view could be using the card view widget for the photo, and recipe details.

Is your peer making anything cool or awesome that you would like to note or applaud them on?
flipping the card is really cool!

3. Does the project appear to follow correct coding styles and best practices? Write up one sentence on your findings and give a score 0-3.
score = 3
Looks good, i'm not a big fan of the short acronym type variable names, but for the linear layout manager on the recycler view, it makes sense.

Are you able to reasonably follow the code without having anyone answer your questions?
Are you able to make sense of what the code is doing or is trying to do?
surprisingly, i'm able to follow the code ok without need to check.

4. Find two pieces of code of any size: one that is readable and easy to follow and one that is difficult to follow and understand.
all of the object animators in the separate xml files are new to me, and find those to be the most difficult code pieces in the project (so far).

What makes the readable code readable? Be as detailed as you can in your answer, it can be challenging to explain why something is easy to undertand

What makes the difficult code harder to follow? Be as detailed as you can in your answer.
i'd say the interpolator is where i'd need some clarification, but its not the authors fault.

**5. High level project overview: Take a look at as many individual files as you have time for

Does this class make sense?
Does the structure of the class make sense?
Is it clear what this class is supposed to do?**

good job, hoping your studio installation issues get resolved.