ui(members): adopt PageHeader/PageBody and explain why no group can be added#47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two issues on the project members page, both visible the moment an admin or owner lands on it.
MembersPagerendered its own<Breadcrumbs>+ custompl-14 pr-4 py-4 md:p-8wrapper, so it didn't pick up the sticky header / centered body pattern that every other project page uses (Bugs, Executions, Plans, Versions, Coverage, Custom Fields). Refactored to the sharedPageHeader+PageBodyprimitives, kept the breadcrumb trail, and centered the content withmax-w-4xl. While here, the inline "add member" form getsflex-wrapso the three controls reflow on narrow viewports instead of overflowing.ProjectGroupsSectiononly rendered the assign form when there was at least one unassigned candidate group. If no groups existed yet, or every existing group was already on the project, the form vanished with no explanation and the admin had no way to know why. Added a small hint paragraph below the assignment list:groups.noCandidatesEmpty/groups.noCandidatesAllAssignedtranslated across EN/ES/CA/GL/EU.ProjectGroupsSection.test.jsxgets two new cases that mock the empty/exhausted candidate states and assert the right hint renders.Frontend suite: 377 passing.