-
Notifications
You must be signed in to change notification settings - Fork 3
Rewrite #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Rewrite #65
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
0ed343b
feat(tests): add comprehensive unit tests for CellMapDataset, CellMap…
rhoadesScholar 754dddb
feat: support 5-column CSV format in CellMapDataSplit for challenge d…
rhoadesScholar b567f51
feat: enhance CellMapDataset and CellMapImage for better handling of …
rhoadesScholar bf9de7e
feat: improve handling of 2D array specs in CellMapDataset and EmptyI…
rhoadesScholar d0c0480
feat: implement seeding for reproducible data augmentation in CellMap…
rhoadesScholar ab59d78
fix: remove unused import of Subset from DataLoader in dataloader.py …
rhoadesScholar 675b614
Potential fix for pull request finding
rhoadesScholar 057f91c
Initial plan
Copilot b5dd7ae
Initial plan
Copilot 911d9a6
Initial plan
Copilot a1883ec
fix: remove scalar write support from ImageWriter and CellMapDatasetW…
Copilot 78bef7a
Remove scalar write support from ImageWriter
Copilot ab1bf11
Fix total_voxels to use actual data volume spatial shape
Copilot ce2a150
Merge pull request #67 from janelia-cellmap/copilot/sub-pr-65-again
rhoadesScholar 88d3d08
Merge branch 'rewrite' into copilot/sub-pr-65-yet-again
rhoadesScholar b2db1b6
Potential fix for pull request finding
rhoadesScholar 357f2e0
Update src/cellmap_data/dataset.py
rhoadesScholar 71e1832
Merge branch 'rewrite' into copilot/sub-pr-65
rhoadesScholar 9fa8953
black format
rhoadesScholar 3ec2dab
Potential fix for pull request finding
rhoadesScholar 99e0dd7
Potential fix for pull request finding
rhoadesScholar 0d4bf5a
Improve total_voxels to use cached bounding_box instead of reopening s0
Copilot 7554d4c
test: add test for scalar-in-batch TypeError and explicit guard in da…
Copilot d26ace8
fix: add type check for written values in CellMapDatasetWriter
rhoadesScholar 8d446cc
refactor: apply rhoadesScholar suggestion - drop else branch, keep np…
Copilot ef33153
Potential fix for pull request finding
rhoadesScholar e3f395d
Merge pull request #66 from janelia-cellmap/copilot/sub-pr-65
rhoadesScholar 31c032c
Merge branch 'rewrite' into copilot/sub-pr-65-yet-again
rhoadesScholar 02f8b6b
Potential fix for pull request finding
rhoadesScholar c6d1338
Potential fix for pull request finding
rhoadesScholar c7141ce
test: add coverage for 0-D array/tensor rejection and unsupported bat…
Copilot 50c3f1d
Merge pull request #69 from janelia-cellmap/copilot/sub-pr-65-yet-again
rhoadesScholar bc8792c
fix: adjust bounding box handling and improve target array writing logic
rhoadesScholar c0cad73
black format
rhoadesScholar 08fd903
Update tests/test_dataset.py
rhoadesScholar 295b90d
Initial plan
Copilot 6c895fa
Fix review comments: unused imports, min_redundant_inds, ClassBalance…
Copilot ddb6246
Update src/cellmap_data/sampler.py
rhoadesScholar 4448a56
Add tests for ClassBalancedSampler edge cases and min_redundant_inds;…
Copilot 6fb390c
Merge pull request #70 from janelia-cellmap/copilot/sub-pr-65
rhoadesScholar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This module’s
__all__no longer exports previously public symbols (e.g.,CellMapBaseDataset,CellMapImageBase,CellMapSubset,MutableSubsetRandomSampler). If this package follows semantic versioning, this is a breaking API change—consider documenting it prominently and/or bumping the major version accordingly.