Make temporary cleanup nonfatal#370
Open
kiwigitops wants to merge 1 commit into
Open
Conversation
Signed-off-by: kiwigitops <kiwisclubco@gmail.com>
Author
|
Quick follow-up on this small fix. The temp cleanup failure can still mask the real recording result, so this is still current from my side. Happy to adjust the warning path if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #303.
Temporary record directories are cleaned up in
Monitor.protect'sfinallyblock. If that cleanup raises, the cleanup failure replaces the actual recording result, so a failure to removeperf.datacan make an otherwise completed run fail.This wraps automatic temp-directory cleanup in
Monitor.try_with, logs a warning on failure, and still returnsDeferred.unitfrom the finalizer. Explicit-working-directorypaths are unchanged because those are not auto-cleaned.Validated:
git diff --check