Skip to content

Parse uppercase flags in perf CBR events#372

Open
jeet-dekivadia wants to merge 1 commit into
janestreet:masterfrom
jeet-dekivadia:codex/parse-uppercase-cbr-flags
Open

Parse uppercase flags in perf CBR events#372
jeet-dekivadia wants to merge 1 commit into
janestreet:masterfrom
jeet-dekivadia:codex/parse-uppercase-cbr-flags

Conversation

@jeet-dekivadia

Copy link
Copy Markdown

Summary

  • accept uppercase letters in the ignored annotation prefix of perf CBR events
  • add a regression using the Ubuntu 24.04 perf script line from the issue

Why

Newer perf output can include an uppercase D marker before the CBR payload. The parser only accepted lowercase annotation text there, so Re.exec raised Not_found before the frequency event could be decoded.

Validation

  • git diff --check
  • exercised the widened CBR pattern against the reported line and confirmed it extracts 3629 MHz
  • added expect coverage for the reported parser path

Fixes #324

Signed-off-by: Jeet Dekivadia <jeet.university@gmail.com>
@jeet-dekivadia

Copy link
Copy Markdown
Author

I rechecked this today while it is waiting for review. The parser change is limited to accepting uppercase annotation flags in perf CBR event lines, matching the shape emitted by newer perf versions such as Ubuntu 24.04's D flag output.

The extraction path for the CBR value is otherwise unchanged; the regression keeps the reported uppercase-flag line decoding to the expected MHz value. DCO is green, and the PR has no red checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"exception raised while parsing perf output" with "cbr: 36 freq: 3629 MHz (450%)"

1 participant