Open attached executables through procfs#374
Open
jeet-dekivadia wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jeet Dekivadia <jeet.university@gmail.com>
Author
|
I rechecked this today while it is waiting for review. The patch stays on the attach path: when magic-trace is reading symbols for an already-running target, it opens the executable through procfs so the path is resolved in the target process context instead of the tracer's current mount namespace. The startup/non-attach path still uses the existing executable resolution. DCO is green, and the PR has no red checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/proc/<pid>/exeintact while loading an attached process executable/proc/<pid>/mapsrealpathbehavior for ordinary executable pathsFixes #307.
Why both paths are needed
For a process in another mount namespace,
/proc/<pid>/exeremains openable from the host even when its symlink target, such as/app/server, is not present in the host filesystem. Concretely,readlink("/proc/123/exe")can return/app/serverwhileopen("/app/server")fails on the host andopen("/proc/123/exe")succeeds. The maps file still reports/app/server, so stop-filter address calculation needs thereadlinkresult for its pathname comparison while ELF loading needs the procfs path itself.Validation
git diff --checkreadlink