Stop attach sessions when perf exits#375
Open
jeet-dekivadia wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jeet Dekivadia <jeet.university@gmail.com>
Author
|
Small follow-up for review context. This remains scoped to attach-session shutdown: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitpidESRCHwhen snapshot or shutdown signals race an already-exited recorderWhy
In attach mode, killing the traced process makes
perf recordexit, but magic-trace only waits for Ctrl-C or a breakpoint snapshot. That leaves the command hanging after the tracee is gone. Sharing the recorder completion result also keeps shutdown from attempting a second reap.Fixes #312
Validation
git diff --checkwaitpidflow staticallyPerf_tool_backend.Recordingis the onlyBackend_intf.S.Recordingimplementation and that monitoring plus final cleanup share the same cachedwaitpiddeferred