Detect perf capabilities for kernel tracing#380
Open
Abhishek21g wants to merge 3 commits into
Open
Conversation
Signed-off-by: Abhishek Enaguthi <enaguthiabhishek@gmail.com>
Author
|
I noticed the older related PR #254 after opening this. Since that PR appears stale and #94 is still open, I put together a smaller version that keeps the existing capability detection structure, falls back to the current root-only behavior when getcap is unavailable, and adds focused expect tests for the parser. Happy to adjust direction if maintainers prefer reviving #254. |
Signed-off-by: Abhishek Enaguthi <enaguthiabhishek@gmail.com>
Signed-off-by: Abhishek Enaguthi <enaguthiabhishek@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cap_perfmon/cap_sys_adminfile capabilities on the configuredperfexecutablegetcapis unavailable or cannot inspectperfgetcapoutput parsingFixes #94.
Notes
This keeps the existing capability detection structure and only broadens the kernel-tracing permission check. If
getcapis unavailable or cannot inspect the configuredperf, magic-trace keeps the previous root-only behavior.Validation
git diff --checkdune build @fmtmake PROFILE=staticdune runtest --profile=staticOptional non-root capability smoke test on a disposable Linux machine: