Skip to content

MSVC compilation and runtime fixes - #15

Open
jonahbeckford wants to merge 2 commits into
janestreet:masterfrom
jonahbeckford:fix-msvc
Open

MSVC compilation and runtime fixes#15
jonahbeckford wants to merge 2 commits into
janestreet:masterfrom
jonahbeckford:fix-msvc

Conversation

@jonahbeckford

@jonahbeckford jonahbeckford commented Feb 11, 2024

Copy link
Copy Markdown

Changes:

  1. Fix MSVC runtime error:

    Fatal error: cannot load shared library dllshexp_bigstring_io_stubs
    Reason: Cannot resolve send
    
  2. Fix MSVC compilation error:

    Local variable `char* buf` is overloaded with parameter `value buf`
    
    bigstring_io_stubs.c(44): error C2082: redefinition of formal parameter 'buf'
    bigstring_io_stubs.c(74): error C2082: redefinition of formal parameter 'buf'
    
  3. Likely ancient refactor missed Windows code ... no src variable.

Testing

$ opam exec --switch Y:\source\dksdk-type -- dune utop process-lib/src

────────────────────────────────────────────────────────────────────────────────┬──────────────────────────────────────────────────────────────┬────────────────────────────────────────────────────────────────────────────────                                                                                │ Welcome to utop version 2.13.1 (using OCaml version 4.14.0)! │                                                                                                                                                                └──────────────────────────────────────────────────────────────┘

Type #utop_help for help about using utop.

─( 19:41:45 )─< command 0 >──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────{ counter: 0 }─
utop # open Shexp_process;;
─( 19:41:45 )─< command 1 >──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────{ counter: 0 }─
utop # eval (run {|C:\Program Files\Git\cmd\git.exe|} ["status"]) ;;
On branch v0.16-msvc
Your branch is ahead of 'origin/v0.16-msvc' by 1 commit.
  (use "git push" to publish your local commits)

nothing to commit, working tree clean
- : unit = ()

1. Local variable `char* buf` is overloaded with parameter `value buf`

bigstring_io_stubs.c(44): error C2082: redefinition of formal parameter 'buf'
bigstring_io_stubs.c(74): error C2082: redefinition of formal parameter 'buf'

2. Likely ancient refactor missed Windows code ... no `src` variable.

Signed-off-by: Jonah Beckford <71855677+jonahbeckford@users.noreply.github.com>
1. Fatal error: cannot load shared library dllshexp_bigstring_io_stubs
Reason: Cannot resolve send

Signed-off-by: Jonah Beckford <71855677+jonahbeckford@users.noreply.github.com>
@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants