Open
Conversation
Contributor
|
nice |
some imporvements for the daemon function... kill now needs a pidfile to kill...
Author
|
pushed an update, should i create a new pull request? |
|
@cytec no, when you push to the same branch as your pull request is from, the commits get added to the pull request. |
Author
|
@packetcollision k thx for the info, ill guess ive just whait for @Eichhoernchen to review it ;) |
|
Hello, on CentOS 6 ... i can't run the daemon as service ... [root~]# service siricore start Why ? THxx !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added basic support to run SiriServer as a daemon, also a kill function to kill a daeminized server.
this is my first pull request, hope everything is done right :)