Suppress PasswordDeleteError in ChainerBackend.delete_password#744
Open
bysiber wants to merge 1 commit intojaraco:mainfrom
Open
Suppress PasswordDeleteError in ChainerBackend.delete_password#744bysiber wants to merge 1 commit intojaraco:mainfrom
bysiber wants to merge 1 commit intojaraco:mainfrom
Conversation
When deleting a password through ChainerBackend, if the highest-priority backend raises PasswordDeleteError (because it doesn't hold that particular password), the chainer now catches the error and continues to the next backend instead of propagating immediately. This matches the existing pattern for NotImplementedError and fixes the case where a password exists in a lower-priority backend but cannot be deleted because a higher-priority backend fails first. Fixes jaraco#697
mitya57
reviewed
Feb 22, 2026
Collaborator
There was a problem hiding this comment.
Please don't commit this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #697.
When using
ChainerBackend, deleting a password that only exists in a lower-priority backend fails because the higher-priority backend raisesPasswordDeleteErrorand the chainer doesn't catch it.For example, if
kwallet(priority 5.1) doesn't hold the password butSecretService(priority 5) does, the delete propagates thePasswordDeleteErrorfrom kwallet without ever trying SecretService.This adds
PasswordDeleteErroralongside the already-caughtNotImplementedErrorindelete_password, so the chainer falls through to the next backend the same way it already does forset_password.Added a test covering this scenario.