Conversation
Bring the phpfpm image repo to the same compliance bar as phpcli: - Smoke tests (support/makefiles/test.mk): build per-arch test images and verify php-fpm actually boots & is healthy, all extensions load, OPcache+JIT are active, and the nginx vhost renders to a valid config (nginx -t). - Push guard: run the smoke tests before the push steps and skip pushing on pull_request events, so PRs validate without publishing. - hadolint job + .hadolint.yaml (DL3018, DL4006 — both deliberate base-image decisions). Removed a `|| true` in src/php/Dockerfile that masked the entire build RUN stage. - entrypoint.sh: run the php-fpm master and workers as appuser (chown stdio pipes once as root, then drop) — no root service, dev bind-mount UID remap preserved. - Trivy report job (continue-on-error) writing a vuln summary to the run. - Immutable date tags (:8.x-YYYYMMDD, :1.28-YYYYMMDD) alongside the moving tags. - README: moving vs. immutable tag guidance; test targets documented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release-PR: bringt die in #3 nach
developgemergten Image-Compliance-Änderungen nachmain. Der main-Push publiziert die Images (moving + Datums-Tags) auf Docker Hub.Inhalt (P2-phpfpm F0–F6)
-t).hadolint.yaml;|| trueinsrc/php/Dockerfileentfernt:8.x-YYYYMMDD,:1.28-YYYYMMDD)Beweis aus PR #3 (develop)
hadolint ✅ · build-nginx ✅ · build-phpfpm 8.2/8.3/8.4 ✅ (Tests liefen, Push auf PR übersprungen). Der main-Run beweist zusätzlich die Datums-Tags (multi-arch) und die Trivy-Summary.